Fix the minimal module type.#19
Merged
Merged
Conversation
The code that generates the `minimal` module type is supposed, at some point, to select classes, individuals, and annotation properties. However, the rule is incorrectly written as --select "classes individual annotation-properties" which is incorrect because the keyword that ROBOT expects to select individuals is `individuals` (with a final `-s`) -- `individual` without a `-s` is ignored.
Contributor
|
Sorry about being late on this, maybe 6 or so: https://github.com/search?q=%22module_type%3A+minimal%22+path%3Asrc%2Fontology%2F*-odk.yaml&type=code |
Collaborator
Author
|
Thanks for the search. Projects that use But ELMO is using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
minimalmodule type (found when looking at the definition of that module while thinking about INCATools/ontology-development-kit#1352).The code that generates the
minimalmodule type is supposed, at some point, to select classes, individuals, and annotation properties.However, the rule is incorrectly written as
which is incorrect because the keyword that ROBOT expects to select individuals is
individuals(with a final-s) --individualwithout a-sis ignored.Interestingly, nobody ever reported that bug, meaning either that nobody has ever used the
minimalmodule type, or that nobody has ever noticed that individuals were not properly selected as they should!